Skip to content

fix: approve trusted MCP tools by default#49

Merged
jomeswang merged 1 commit into
mainfrom
agent/mcp-default-approve
Jul 17, 2026
Merged

fix: approve trusted MCP tools by default#49
jomeswang merged 1 commit into
mainfrom
agent/mcp-default-approve

Conversation

@jomeswang

@jomeswang jomeswang commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • default run-scoped MCP servers to defaultToolsApprovalMode: approve while preserving explicit overrides
  • emit Codex default_tools_approval_mode per MCP server
  • map Claude full-access to --dangerously-skip-permissions
  • bump @tutti-os/agent-acp-kit to 0.7.3 and document the trusted local behavior

Test evidence

  • pnpm typecheck
  • pnpm exec vitest run tests --maxWorkers=1 (215 passed)
  • pnpm build
  • pnpm pack:check
  • pnpm test:packed-consumer

The default parallel test invocation hit unrelated subprocess timing flakes on this host; serial execution passed the full suite.

Risk

  • MCP tools now run without an approval prompt unless a host explicitly sets auto, prompt, or writes. This is intended for run-scoped application MCP servers carrying short-lived host tokens.
  • Claude full-access now uses the CLI-native skip-permissions flag instead of the permission-mode alias.

AI assistance

Implementation and tests were prepared with Codex assistance.


Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@jomeswang
jomeswang merged commit 73dddae into main Jul 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant